From 7932d2e2d47f5a0543b7ee46a4a6ac76037219c0 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 13 Nov 2006 19:15:43 +0100 Subject: [PATCH] * src/sort.c (insertkey): Use xmemdup, rather than xmalloc+assignment. From Paul Eggert. --- ChangeLog | 3 +++ src/sort.c | 3 +-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index e737ee1739..c4e225296c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2006-11-13 Jim Meyering + * src/sort.c (insertkey): Use xmemdup, rather than xmalloc+assignment. + From Paul Eggert. + Plug another technically-unimportant leak in sort. * src/sort.c (main): Don't allocate memory for each new key here. (insertkey): Allocate memory for each key here, instead. diff --git a/src/sort.c b/src/sort.c index bdaf032a3c..feaf5a5bc1 100644 --- a/src/sort.c +++ b/src/sort.c @@ -2105,9 +2105,8 @@ static void insertkey (struct keyfield *key_arg) { struct keyfield **p; - struct keyfield *key = xmalloc (sizeof *key); + struct keyfield *key = xmemdup (key_arg, sizeof *key); - *key = *key_arg; for (p = &keylist; *p; p = &(*p)->next) continue; *p = key; -- 2.47.3