From 7a591e90e3359fd995c858282b0865519c40bb14 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Fri, 4 Jun 2021 12:32:34 -0700 Subject: [PATCH] s3: smbd: Cleanup - fix the comment for dptr_SearchDir(). It doesn't and never has skipped VETO or unreadable files. It's only used in call_trans2findnext() in the SMB1 code given a name already returned to the client to find a resume position. Even if the client gave us a name that it had never been given to it (client bug or malicious client) we'd just start the search from the wrong position, which doesn't cause problems (we still check for VETO or unreadable before returning any names). Worst thing that actually happens is the client messes up their own search, which is what you'd expect from giving an incorrect resume name. Signed-off-by: Jeremy Allison Reviewed-by: Ralph Boehme --- source3/smbd/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/smbd/dir.c b/source3/smbd/dir.c index 9d5244e3c4e..946d86de3fd 100644 --- a/source3/smbd/dir.c +++ b/source3/smbd/dir.c @@ -559,7 +559,7 @@ ret: } /**************************************************************************** - Search for a file by name, skipping veto'ed and not visible files. + Search for a file by name. ****************************************************************************/ bool dptr_SearchDir(struct dptr_struct *dptr, const char *name, long *poffset, SMB_STRUCT_STAT *pst) -- 2.47.3