From 7e1e45a9e42efb77a44f331e5220cdc820a8d924 Mon Sep 17 00:00:00 2001 From: David Sterba Date: Tue, 6 Jan 2026 17:20:24 +0100 Subject: [PATCH] btrfs: remove duplicate calculation of eb offset in btrfs_bin_search() In the main search loop the variable 'oil' (offset in folio) is set twice, one duplicated when the key fits completely to the contiguous range. We can remove it and while it's just a simple calculation, the binary search loop is executed many times so micro optimizations add up. The code size is reduced by 64 bytes on release config, the loop is reorganized a bit and a few instructions shorter. Reviewed-by: Boris Burkov Signed-off-by: David Sterba --- fs/btrfs/ctree.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index 5c68c541de516..eae69e205b288 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -781,7 +781,6 @@ int btrfs_bin_search(const struct extent_buffer *eb, int first_slot, const unsigned long idx = get_eb_folio_index(eb, offset); char *kaddr = folio_address(eb->folios[idx]); - oil = get_eb_offset_in_folio(eb, offset); tmp = (struct btrfs_disk_key *)(kaddr + oil); } else { read_extent_buffer(eb, &unaligned, offset, key_size); -- 2.47.3