From 85ab0501f46b473e4283dd2df9f9b74a89ad9021 Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Mon, 31 Dec 2007 10:23:21 +0000 Subject: [PATCH] filter() criterion takes mapper equivalent_columns into account when it adapts to select_table. more to come in [ticket:917] . --- lib/sqlalchemy/orm/query.py | 4 +++- test/orm/inheritance/polymorph.py | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/sqlalchemy/orm/query.py b/lib/sqlalchemy/orm/query.py index dd7fa638e7..83065a73d4 100644 --- a/lib/sqlalchemy/orm/query.py +++ b/lib/sqlalchemy/orm/query.py @@ -929,8 +929,10 @@ class Query(object): # be adapted to be relative to the user-supplied selectable. adapt_criterion = self.table not in self._get_joinable_tables() + # adapt for poylmorphic mapper + # TODO: generalize the polymorphic mapper adaption to that of the select_from() adaption if not adapt_criterion and whereclause is not None and (self.mapper is not self.select_mapper): - whereclause = sql_util.ClauseAdapter(from_obj).traverse(whereclause) + whereclause = sql_util.ClauseAdapter(from_obj, equivalents=self.select_mapper._get_equivalent_columns()).traverse(whereclause) # TODO: mappers added via add_entity(), adapt their queries also, # if those mappers are polymorphic diff --git a/test/orm/inheritance/polymorph.py b/test/orm/inheritance/polymorph.py index e45a11a542..f9ac6199c7 100644 --- a/test/orm/inheritance/polymorph.py +++ b/test/orm/inheritance/polymorph.py @@ -269,6 +269,10 @@ def generate_round_trip_test(include_base=False, lazy_relation=True, redefine_co assert getattr(dilbert, person_attribute_name) == 'dilbert' session.clear() + dilbert = session.query(Person).filter(Person.person_id==dilbert.person_id).one() + assert getattr(dilbert, person_attribute_name) == 'dilbert' + session.clear() + id = c.company_id def go(): c = session.query(Company).get(id) -- 2.47.3