From 85c7333c35f22cdb8391b4cacfdc496aec4162ae Mon Sep 17 00:00:00 2001 From: Daniel Zahka Date: Thu, 18 Sep 2025 14:27:20 -0700 Subject: [PATCH] psp: clarify checksum behavior of psp_dev_rcv() psp_dev_rcv() decapsulates psp headers from a received frame. This will make any csum complete computed by the device inaccurate. Rather than attempt to patch up skb->csum in psp_dev_rcv() just make it clear to callers what they can expect regarding checksum complete. Signed-off-by: Daniel Zahka Link: https://patch.msgid.link/20250918212723.17495-1-daniel.zahka@gmail.com Signed-off-by: Jakub Kicinski --- net/psp/psp_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/psp/psp_main.c b/net/psp/psp_main.c index 0f8c50c8e9435..481aaf0fc9fcf 100644 --- a/net/psp/psp_main.c +++ b/net/psp/psp_main.c @@ -228,7 +228,8 @@ EXPORT_SYMBOL(psp_dev_encapsulate); * Presently it accepts only already-authenticated packets and does not * support optional fields, such as virtualization cookies. The caller should * ensure that skb->data is pointing to the mac header, and that skb->mac_len - * is set. + * is set. This function does not currently adjust skb->csum (CHECKSUM_COMPLETE + * is not supported). */ int psp_dev_rcv(struct sk_buff *skb, u16 dev_id, u8 generation, bool strip_icv) { -- 2.47.3