From 866b8dcb54750304371fa2457c1b1f859328049e Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Fri, 10 Jun 2022 13:05:37 +0200 Subject: [PATCH] s4:client: Fix shellcheck errors in test_smbclient.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit source4/client/tests/test_smbclient.sh:31:99: error: Double quote array expansions to avoid re-splitting elements. [SC2068] source4/client/tests/test_smbclient.sh:41:116: error: Double quote array expansions to avoid re-splitting elements. [SC2068] source4/client/tests/test_smbclient.sh:43:94: error: Double quote array expansions to avoid re-splitting elements. [SC2068] Signed-off-by: Andreas Schneider Reviewed-by: Pavel Filipenský --- source4/client/tests/test_smbclient.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/source4/client/tests/test_smbclient.sh b/source4/client/tests/test_smbclient.sh index 1d87f90e601..121de173063 100755 --- a/source4/client/tests/test_smbclient.sh +++ b/source4/client/tests/test_smbclient.sh @@ -28,7 +28,7 @@ runcmd() shift shift echo "test: $name" - $VALGRIND $smbclient $CONFIGURATION //$SERVER/tmp -c "$cmd" -W "$DOMAIN" -U"$USERNAME%$PASSWORD" $@ + $VALGRIND $smbclient $CONFIGURATION //$SERVER/tmp -c "$cmd" -W "$DOMAIN" -U"$USERNAME%$PASSWORD" "$@" status=$? if [ x$status = x0 ]; then echo "success: $name" @@ -38,9 +38,9 @@ runcmd() return $status } -testit "share and server list" $VALGRIND $smbclient -L $SERVER $CONFIGURATION -W "$DOMAIN" -U"$USERNAME%$PASSWORD" $@ || failed=$(expr $failed + 1) +testit "share and server list" $VALGRIND $smbclient -L $SERVER $CONFIGURATION -W "$DOMAIN" -U"$USERNAME%$PASSWORD" "$@" || failed=$(expr $failed + 1) -testit "share and server list anonymously" $VALGRIND $smbclient -N -L $SERVER $CONFIGURATION $@ || failed=$(expr $failed + 1) +testit "share and server list anonymously" $VALGRIND $smbclient -N -L $SERVER $CONFIGURATION "$@" || failed=$(expr $failed + 1) # Use the smbclient binary as our test file cat $smbclient >$PREFIX/tmpfile -- 2.47.3