From 867c1fe0187f6df4dca84a34332e00f21ef80f69 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Thu, 14 Sep 2023 12:47:44 +0300 Subject: [PATCH] bcachefs: fix error checking in bch2_fs_alloc() There is a typo here where it uses ";" instead of "?:". The result is that bch2_fs_fs_io_direct_init() is called unconditionally and the errors from it are not checked. Fixes: 0060c68159fc ("bcachefs: Split up fs-io.[ch]") Signed-off-by: Dan Carpenter Signed-off-by: Kent Overstreet Reviewed-by: Brian Foster --- fs/bcachefs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c index 2990eed85adf5..e94a63a22704a 100644 --- a/fs/bcachefs/super.c +++ b/fs/bcachefs/super.c @@ -852,7 +852,7 @@ static struct bch_fs *bch2_fs_alloc(struct bch_sb *sb, struct bch_opts opts) bch2_fs_compress_init(c) ?: bch2_fs_ec_init(c) ?: bch2_fs_fsio_init(c) ?: - bch2_fs_fs_io_buffered_init(c); + bch2_fs_fs_io_buffered_init(c) ?: bch2_fs_fs_io_direct_init(c); if (ret) goto err; -- 2.47.3