From 875e99dc30d543bfee8cf0d87c75d7f362831f7e Mon Sep 17 00:00:00 2001 From: Shawn Routhier Date: Wed, 9 Sep 2009 19:05:17 +0000 Subject: [PATCH] Fix the check in the signal handler code to check if there is an inner signal handler before calling it. Previously we check if there was a get_value function. --- RELNOTES | 3 +++ common/discover.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/RELNOTES b/RELNOTES index feca625c1..5181e0eb1 100644 --- a/RELNOTES +++ b/RELNOTES @@ -186,6 +186,9 @@ work on other platforms. Please report any problems and suggested fixes to - Fixed a fenceposting bug when a client had two host records configured, one using 'uid' and the other using 'hardware ethernet'. +- Fixed the check in the dhcp_interface_signal_handler routine to verify + the existence of the linked signal handler before calling it. + Changes since 4.1.0b1 - A missing "else" in dhcrelay.c could have caused an interface not to diff --git a/common/discover.c b/common/discover.c index 6ade7f629..7e32b6465 100644 --- a/common/discover.c +++ b/common/discover.c @@ -1559,7 +1559,7 @@ isc_result_t dhcp_interface_signal_handler (omapi_object_t *h, } /* Try to find some inner object that can take the value. */ - if (h -> inner && h -> inner -> type -> get_value) { + if (h -> inner && h -> inner -> type -> signal_handler) { status = ((*(h -> inner -> type -> signal_handler)) (h -> inner, name, ap)); if (status == ISC_R_SUCCESS) -- 2.47.3