From 8a27396341c4339552ce1aa572393c7dd4ec54ac Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Thu, 17 Mar 2011 01:03:03 +1300 Subject: [PATCH] Remove useless checks and debug. size_t is guaranteed to be signed Detected by ICC. --- src/helper.cc | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/helper.cc b/src/helper.cc index 6c313cbd1e..c7f62b2879 100644 --- a/src/helper.cc +++ b/src/helper.cc @@ -862,12 +862,8 @@ helperHandleRead(int fd, char *buf, size_t len, comm_err_t flag, int xerrno, voi debugs(84, 5, "helperHandleRead: " << len << " bytes from " << hlp->id_name << " #" << srv->index + 1); - if (flag != COMM_OK || len <= 0) { - if (len < 0) - debugs(84, 1, "helperHandleRead: FD " << fd << " read: " << xstrerror()); - + if (flag != COMM_OK || len == 0) { comm_close(fd); - return; } @@ -936,12 +932,8 @@ helperStatefulHandleRead(int fd, char *buf, size_t len, comm_err_t flag, int xer hlp->id_name << " #" << srv->index + 1); - if (flag != COMM_OK || len <= 0) { - if (len < 0) - debugs(84, 1, "helperStatefulHandleRead: FD " << fd << " read: " << xstrerror()); - + if (flag != COMM_OK || len == 0) { comm_close(fd); - return; } -- 2.47.3