From 8aed7e9aae13b3fc64a2af1fbdf835f12038ac9b Mon Sep 17 00:00:00 2001 From: Noel Power Date: Wed, 10 Jul 2019 16:13:38 +0100 Subject: [PATCH] s4/libcli/ldab: clang: Fix 'Access results in a deref of a null pointer' Fixes: source4/libcli/ldap/ldap_client.c:1023:6: warning: Access to field 'type' results in a dereference of a null pointer <--[clang] if ((*msg)->type != type) { ^~~~~~~~~~~~ Signed-off-by: Noel Power Reviewed-by: Gary Lockyer --- source4/libcli/ldap/ldap_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/libcli/ldap/ldap_client.c b/source4/libcli/ldap/ldap_client.c index da84adc7769..a5defbcb4e3 100644 --- a/source4/libcli/ldap/ldap_client.c +++ b/source4/libcli/ldap/ldap_client.c @@ -1020,7 +1020,7 @@ _PUBLIC_ NTSTATUS ldap_result_one(struct ldap_request *req, struct ldap_message if (!NT_STATUS_IS_OK(status)) { return status; } - if ((*msg)->type != type) { + if ((*msg) != NULL && (*msg)->type != type) { *msg = NULL; return NT_STATUS_UNEXPECTED_NETWORK_ERROR; } -- 2.47.3