From 8e989a1afbdb024ae9200d89f18a5b107b181a98 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Fri, 22 Jul 2016 16:06:45 +0200 Subject: [PATCH] tevent: Save 140 bytes of .text in tevent_req_create This is one of or hottest code paths, I think every bit counts here. Signed-off-by: Volker Lendecke Reviewed-by: Stefan Metzmacher --- lib/tevent/tevent_req.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/lib/tevent/tevent_req.c b/lib/tevent/tevent_req.c index 2d9cc6db574..fe613cc834c 100644 --- a/lib/tevent/tevent_req.c +++ b/lib/tevent/tevent_req.c @@ -77,16 +77,14 @@ struct tevent_req *_tevent_req_create(TALLOC_CTX *mem_ctx, .internal.trigger = tevent_create_immediate(req) }; - if (!req->internal.trigger) { - talloc_free(req); - return NULL; - } - data = talloc_zero_size(req, data_size); - if (data == NULL) { - talloc_free(req); - return NULL; - } + + /* + * No need to check for req->internal.trigger!=NULL or + * data!=NULL, this can't fail: talloc_pooled_object has + * already allocated sufficient memory. + */ + talloc_set_name_const(data, type); req->data = data; -- 2.47.3