From 8f084aafe81c47468fd7e0091a462b34bfd3e132 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Tue, 13 Nov 2012 19:30:30 -0700 Subject: [PATCH] unlinkd: Compiler warning cleanups Check the return value for open(/dev/null). Nothing we can do about it since the daemon has already disconnected from cache.log but note that. Detected by Coverity Scan. Issue 740328 --- src/unlinkd_daemon.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/unlinkd_daemon.cc b/src/unlinkd_daemon.cc index a143a82625..c621e1c464 100644 --- a/src/unlinkd_daemon.cc +++ b/src/unlinkd_daemon.cc @@ -77,9 +77,11 @@ main(int argc, char *argv[]) setbuf(stdin, NULL); setbuf(stdout, NULL); close(2); - open(_PATH_DEVNULL, O_RDWR); + if (open(_PATH_DEVNULL, O_RDWR) < 0) { + ; // the irony of having to close(2) earlier is that we cannot report this failure. + } - while (fgets(buf, UNLINK_BUF_LEN, stdin)) { + while (fgets(buf, sizeof(buf), stdin)) { if ((t = strchr(buf, '\n'))) *t = '\0'; x = unlink(buf); -- 2.47.3