From 9312bdd271f2d1b8d0ac84507d92df1f65b82a73 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Thu, 28 Nov 2024 18:41:50 +0100 Subject: [PATCH] libcli: Simplify disp_sec_ace_object() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Directly use GUID_buf_string() Signed-off-by: Volker Lendecke Reviewed-by: Pavel Filipenský --- libcli/security/display_sec.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libcli/security/display_sec.c b/libcli/security/display_sec.c index be89a33f176..33fe77b8f25 100644 --- a/libcli/security/display_sec.c +++ b/libcli/security/display_sec.c @@ -110,20 +110,18 @@ void display_sec_ace_flags(uint8_t flags) ****************************************************************************/ static void disp_sec_ace_object(struct security_ace_object *object) { - char *str; + struct GUID_txt_buf buf; + if (object->flags & SEC_ACE_OBJECT_TYPE_PRESENT) { - str = GUID_string(NULL, &object->type.type); - if (str == NULL) return; printf("Object type: SEC_ACE_OBJECT_TYPE_PRESENT\n"); - printf("Object GUID: %s\n", str); - talloc_free(str); + printf("Object GUID: %s\n", + GUID_buf_string(&object->type.type, &buf)); } if (object->flags & SEC_ACE_INHERITED_OBJECT_TYPE_PRESENT) { - str = GUID_string(NULL, &object->inherited_type.inherited_type); - if (str == NULL) return; printf("Object type: SEC_ACE_INHERITED_OBJECT_TYPE_PRESENT\n"); - printf("Object GUID: %s\n", str); - talloc_free(str); + printf("Object GUID: %s\n", + GUID_buf_string(&object->inherited_type.inherited_type, + &buf)); } } -- 2.47.3