From 93379df97781efb03d5fea39e89efcbcaacc2eba Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Thu, 30 Nov 2023 15:31:32 +1300 Subject: [PATCH] =?utf8?q?librpc:ndr:=20Don=E2=80=99t=20unnecessarily=20pa?= =?utf8?q?renthesize=20macro=20arguments?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If we’re just passing a parameter to another macro which we know correctly parenthesizes its arguments, then we don’t need to parenthesize the parameter ourselves. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- librpc/ndr/ndr_basic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/librpc/ndr/ndr_basic.c b/librpc/ndr/ndr_basic.c index eae0fd062cb..fc8620f28c7 100644 --- a/librpc/ndr/ndr_basic.c +++ b/librpc/ndr/ndr_basic.c @@ -37,7 +37,7 @@ (int32_t)(NDR_BE(ndr) ? PULL_BE_U32(ndr->data,ofs) : PULL_LE_U32(ndr->data,ofs)) #define NDR_PULL_I64(ndr, ofs) \ - (NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, (ofs)) : PULL_LE_I64((ndr)->data, (ofs))) + (NDR_BE(ndr) ? PULL_BE_I64((ndr)->data, ofs) : PULL_LE_I64((ndr)->data, ofs)) #define NDR_PUSH_U16(ndr, ofs, v) \ do { \ @@ -69,9 +69,9 @@ #define NDR_PUSH_I64(ndr, ofs, v) \ do { \ if (NDR_BE(ndr)) { \ - PUSH_BE_I64((ndr)->data, (ofs), (v)); \ + PUSH_BE_I64((ndr)->data, ofs, v); \ } else { \ - PUSH_LE_I64((ndr)->data, (ofs), (v)); \ + PUSH_LE_I64((ndr)->data, ofs, v); \ } \ } while (0) -- 2.47.3