From 941ee1485d98e7ac6f4887b28f934a8d3df1933d Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Thu, 9 Feb 2017 15:40:45 +1300 Subject: [PATCH] Fix uninitialized variable in libadaptation The grokBool() parse method does not alter the bool parameter on invalid inputs. This results in encrypt local variable being used uninitialized. --- src/adaptation/ServiceConfig.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/adaptation/ServiceConfig.cc b/src/adaptation/ServiceConfig.cc index ad7f5409c3..1d4697bc84 100644 --- a/src/adaptation/ServiceConfig.cc +++ b/src/adaptation/ServiceConfig.cc @@ -139,7 +139,7 @@ Adaptation::ServiceConfig::parse() grokked = grokOnOverload(onOverload, value); onOverloadSet = true; } else if (strcmp(name, "connection-encryption") == 0) { - bool encrypt; + bool encrypt = false; grokked = grokBool(encrypt, name, value); connectionEncryption.configure(encrypt); } else if (strncmp(name, "ssl", 3) == 0 || strncmp(name, "tls-", 4) == 0) { -- 2.47.3