From 960ae819ade522a72e3b8677fccd8ccd557f9a43 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Thu, 18 Aug 2022 11:52:54 +1200 Subject: [PATCH] samba-tool ldapcmp: use CommandError, not assertion Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- python/samba/netcmd/ldapcmp.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python/samba/netcmd/ldapcmp.py b/python/samba/netcmd/ldapcmp.py index dd34e0cf015..5118e65ca98 100644 --- a/python/samba/netcmd/ldapcmp.py +++ b/python/samba/netcmd/ldapcmp.py @@ -110,7 +110,10 @@ class LDAPBase(object): def find_netbios(self): res = self.ldb.search(base="CN=Partitions,%s" % self.config_dn, scope=SCOPE_SUBTREE, attrs=["nETBIOSName"]) - assert len(res) > 0 + + if len(res) == 0: + raise CommandError("Could not find netbios name") + for x in res: if "nETBIOSName" in x: return x["nETBIOSName"][0] -- 2.47.3