From a07804278533e8e6d946c51447d940a8d0ed9e4d Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Tue, 9 Jan 2018 10:46:40 +0100 Subject: [PATCH] selftest: split a large system invocation line MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Small cleanup for better code readability, no change in behaviour. Signed-off-by: Ralph Boehme Reviewed-by: Andreas Schneider Autobuild-User(master): Ralph Böhme Autobuild-Date(master): Wed Jan 10 05:19:26 CET 2018 on sn-devel-144 --- selftest/target/Samba3.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/selftest/target/Samba3.pm b/selftest/target/Samba3.pm index 17247274b73..f4ae0f3c02f 100755 --- a/selftest/target/Samba3.pm +++ b/selftest/target/Samba3.pm @@ -2468,7 +2468,9 @@ sub wait_for_start($$$$$) $cmd .= "cache del IDMAP/SID2XID/S-1-5-32-545"; system($cmd); - $ret = system("SELFTEST_WINBINDD_SOCKET_DIR=" . $envvars->{SELFTEST_WINBINDD_SOCKET_DIR} . " " . Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545"); + $cmd = "SELFTEST_WINBINDD_SOCKET_DIR='$envvars->{SELFTEST_WINBINDD_SOCKET_DIR}' "; + $cmd .= Samba::bindir_path($self, "wbinfo") . " --sid-to-gid=S-1-5-32-545"; + $ret = system($cmd); if ($ret != 0) { print "Missing \"BUILTIN\\Users\", did net sam createbuiltingroup Users fail?\n"; teardown_env($self, $envvars); -- 2.47.3