From a3572821530063b842da26af29babfca8c51b4cc Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Tue, 22 Sep 2020 13:50:01 +0200 Subject: [PATCH] libsmb: Protect against rogue getaddrinfo result Probably a "won't happen", but to me this looked fishy Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- source3/libsmb/namequery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source3/libsmb/namequery.c b/source3/libsmb/namequery.c index 68c946010fe..bb43cb2f615 100644 --- a/source3/libsmb/namequery.c +++ b/source3/libsmb/namequery.c @@ -2820,7 +2820,9 @@ static NTSTATUS resolve_hosts(TALLOC_CTX *mem_ctx, for (res = ailist; res; res = res->ai_next) { struct sockaddr_storage ss = {0}; - if ((res->ai_addr == NULL) || (res->ai_addrlen == 0)) { + if ((res->ai_addr == NULL) || + (res->ai_addrlen == 0) || + (res->ai_addrlen > sizeof(ss))) { continue; } -- 2.47.3