From a59036365b304d43bba0f050fa9a7d76100e0ae1 Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Fri, 24 Aug 2018 00:59:16 -0400 Subject: [PATCH] closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872) Reported by Svace static analyzer. (cherry picked from commit 2b824b2538c4a5f9f520c5de8a1eae5a0c181a94) Co-authored-by: Alexey Izbyshev --- Python/bltinmodule.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c index 94f290853ccf..6306c3ac5641 100644 --- a/Python/bltinmodule.c +++ b/Python/bltinmodule.c @@ -2431,6 +2431,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start) } } result = PyFloat_FromDouble(f_result); + if (result == NULL) { + Py_DECREF(item); + Py_DECREF(iter); + return NULL; + } temp = PyNumber_Add(result, item); Py_DECREF(result); Py_DECREF(item); -- 2.47.3