From a8b19ebfc81ff4257f410671eb77cfd65c5f1630 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Wed, 8 Jun 2022 14:42:48 +0200 Subject: [PATCH] s3:script: Fix shellcheck errors in test_smbspool.sh MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit test_smbspool.sh:124:24: error: Couldn't parse this test expression. Fix to allow more checks. [SC1073] test_smbspool.sh:124:44: error: If grouping expressions inside [..], use \( ..\). [SC1026] test_smbspool.sh:124:46: error: Expected test to end here (don't wrap commands in []/[[]]). Fix any mentioned problems and try again. [SC1072] Signed-off-by: Andreas Schneider Reviewed-by: Pavel Filipenský --- source3/script/tests/test_smbspool.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source3/script/tests/test_smbspool.sh b/source3/script/tests/test_smbspool.sh index 1c3c02e2502..1fcc9a8cc01 100755 --- a/source3/script/tests/test_smbspool.sh +++ b/source3/script/tests/test_smbspool.sh @@ -121,7 +121,7 @@ test_vlp_verify() fi jobid=$(echo "$out" | awk '/[0-9]+/ { print $1 };') - if [ -z "$jobid" ] || [ $jobid -lt 100 || [ $jobid -gt 2000 ]; then + if [ -z "$jobid" ] || [ $jobid -lt 100 ] || [ $jobid -gt 2000 ]; then echo "Invalid jobid: $jobid" echo "$out" return 1 -- 2.47.3