From a9e6300a5d49182f3c05fd3f11cf056015854820 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Fri, 3 May 2019 09:46:04 +1200 Subject: [PATCH] rpc/dnsdata: do not crash if message attr missing (CID: 1414773) This should be hard to trigger, but goto fail is always nicer than sig 11. Signed-off-by: Douglas Bagnall Reviewed-by: Gary Lockyer --- source4/rpc_server/dnsserver/dnsdata.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source4/rpc_server/dnsserver/dnsdata.c b/source4/rpc_server/dnsserver/dnsdata.c index 59e29f029a6..6a211ad9efd 100644 --- a/source4/rpc_server/dnsserver/dnsdata.c +++ b/source4/rpc_server/dnsserver/dnsdata.c @@ -794,6 +794,11 @@ struct dns_tree *dns_build_tree(TALLOC_CTX *mem_ctx, const char *name, struct ld /* Add all names in the result in a tree */ for (i=0; icount; i++) { ptr = ldb_msg_find_attr_as_string(res->msgs[i], "name", NULL); + if (ptr == NULL) { + DBG_ERR("dnsserver: dns record has no name (%s)", + ldb_dn_get_linearized(res->msgs[i]->dn)); + goto failed; + } if (strcmp(ptr, "@") == 0) { base->data = res->msgs[i]; -- 2.47.3