From aa0a7034df7430d4e65ee3f2f4772699ee37ebe3 Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Sun, 29 May 2011 06:23:12 -0600 Subject: [PATCH] Bug 3226: Tags from external ACLs do not correctly expire --- src/external_acl.cc | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/external_acl.cc b/src/external_acl.cc index ac4e31f524..342e8cb383 100644 --- a/src/external_acl.cc +++ b/src/external_acl.cc @@ -730,12 +730,9 @@ aclMatchExternal(external_acl_data *acl, ACLFilledChecklist *ch) if (acl->def->theHelper->stats.queue_size <= acl->def->theHelper->n_running) { debugs(82, 2, "aclMatchExternal: \"" << key << "\": queueing a call."); - ch->changeState (ExternalACLLookup::Instance()); - - if (entry == NULL) { - debugs(82, 2, "aclMatchExternal: \"" << key << "\": return -1."); - return -1; - } + ch->changeState(ExternalACLLookup::Instance()); + debugs(82, 2, "aclMatchExternal: \"" << key << "\": return -1."); + return -1; // to get here we have to have an expired cache entry. MUST not use. } else { if (!entry) { debugs(82, 1, "aclMatchExternal: '" << acl->def->name << -- 2.47.3