From b1e0e6465a6b641283b89c6692ba4767d4f42ef8 Mon Sep 17 00:00:00 2001 From: Daniele Varrazzo Date: Wed, 25 Aug 2021 03:02:54 +0200 Subject: [PATCH] Drop TODO point after understanding that Windows has no IANA db --- tests/types/test_datetime.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/types/test_datetime.py b/tests/types/test_datetime.py index 6a10bcc7e..a4b756354 100644 --- a/tests/types/test_datetime.py +++ b/tests/types/test_datetime.py @@ -359,20 +359,16 @@ class TestDateTimeTz: assert rec[0] == want assert rec[1] == 11111111 - mark_tz_sec = ( - pytest.mark.skipif( - sys.version_info < (3, 7), reason="no seconds in tz offset" - ), + tz_sec = pytest.mark.skipif( + sys.version_info < (3, 7), reason="no seconds in tz offset" ) - @pytest.mark.xfail( - sys.platform == "win32", reason="TODO why? Missing tzdata?" - ) + @pytest.mark.xfail(sys.platform == "win32", reason="no IANA db on Windows") @pytest.mark.parametrize( "valname, tzval, tzname", [ ("max", "-06", "America/Chicago"), - pytest.param("min", "+09:18:59", "Asia/Tokyo", marks=mark_tz_sec), + pytest.param("min", "+09:18:59", "Asia/Tokyo", marks=[tz_sec]), ], ) @pytest.mark.parametrize("fmt_out", [pq.Format.TEXT, pq.Format.BINARY]) -- 2.47.3