From b6251821a19b1e816a898dd2eca5cbd44468f77c Mon Sep 17 00:00:00 2001 From: Florian Krohm Date: Thu, 30 Apr 2015 20:44:17 +0000 Subject: [PATCH] Remove a few embarassing comments. git-svn-id: svn://svn.valgrind.org/valgrind/trunk@15169 --- coregrind/m_coredump/coredump-elf.c | 1 - coregrind/m_coredump/coredump-macho.c | 1 - coregrind/m_debugger.c | 1 - coregrind/m_debuginfo/debuginfo.c | 1 - coregrind/m_errormgr.c | 1 - coregrind/m_execontext.c | 2 -- coregrind/m_gdbserver/m_gdbserver.c | 3 --- coregrind/m_gdbserver/server.h | 1 - coregrind/m_initimg/initimg-darwin.c | 1 - coregrind/m_initimg/initimg-linux.c | 1 - coregrind/m_libcassert.c | 1 - coregrind/m_machine.c | 1 - coregrind/m_main.c | 1 - coregrind/m_mallocfree.c | 1 - coregrind/m_scheduler/scheduler.c | 1 - coregrind/m_sigframe/sigframe-amd64-darwin.c | 1 - coregrind/m_sigframe/sigframe-amd64-linux.c | 1 - coregrind/m_sigframe/sigframe-arm-linux.c | 1 - coregrind/m_sigframe/sigframe-arm64-linux.c | 1 - coregrind/m_sigframe/sigframe-mips32-linux.c | 1 - coregrind/m_sigframe/sigframe-mips64-linux.c | 1 - coregrind/m_sigframe/sigframe-ppc32-linux.c | 1 - coregrind/m_sigframe/sigframe-ppc64-linux.c | 1 - coregrind/m_sigframe/sigframe-s390x-linux.c | 1 - coregrind/m_sigframe/sigframe-tilegx-linux.c | 1 - coregrind/m_sigframe/sigframe-x86-darwin.c | 1 - coregrind/m_sigframe/sigframe-x86-linux.c | 1 - coregrind/m_signals.c | 1 - coregrind/m_stacktrace.c | 1 - coregrind/m_threadstate.c | 1 - coregrind/m_translate.c | 1 - 31 files changed, 34 deletions(-) diff --git a/coregrind/m_coredump/coredump-elf.c b/coregrind/m_coredump/coredump-elf.c index 6f965d7a86..038b771d5f 100644 --- a/coregrind/m_coredump/coredump-elf.c +++ b/coregrind/m_coredump/coredump-elf.c @@ -42,7 +42,6 @@ #include "pub_core_libcproc.h" // VG_(geteuid), VG_(getegid) #include "pub_core_libcassert.h" // VG_(exit), vg_assert #include "pub_core_mallocfree.h" // VG_(malloc), VG_(free) -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_xarray.h" #include "pub_core_clientstate.h" diff --git a/coregrind/m_coredump/coredump-macho.c b/coregrind/m_coredump/coredump-macho.c index dbd3d6a425..fd5f13a11b 100644 --- a/coregrind/m_coredump/coredump-macho.c +++ b/coregrind/m_coredump/coredump-macho.c @@ -33,7 +33,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_coredump.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" void VG_(make_coredump)(ThreadId tid, const vki_siginfo_t *si, ULong max_size) diff --git a/coregrind/m_debugger.c b/coregrind/m_debugger.c index fc7169a1dd..4582db0d5b 100644 --- a/coregrind/m_debugger.c +++ b/coregrind/m_debugger.c @@ -30,7 +30,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" #include "pub_core_threadstate.h" #include "pub_core_xarray.h" #include "pub_core_clientstate.h" diff --git a/coregrind/m_debuginfo/debuginfo.c b/coregrind/m_debuginfo/debuginfo.c index 1fcc6127fc..31fd369bb4 100644 --- a/coregrind/m_debuginfo/debuginfo.c +++ b/coregrind/m_debuginfo/debuginfo.c @@ -32,7 +32,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_debuginfo.h" /* self */ #include "pub_core_demangle.h" diff --git a/coregrind/m_errormgr.c b/coregrind/m_errormgr.c index bcdd2a060b..2ea6370f16 100644 --- a/coregrind/m_errormgr.c +++ b/coregrind/m_errormgr.c @@ -30,7 +30,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" #include "pub_core_threadstate.h" // For VG_N_THREADS #include "pub_core_debugger.h" #include "pub_core_debuginfo.h" diff --git a/coregrind/m_execontext.c b/coregrind/m_execontext.c index 9472b30a65..f738279d49 100644 --- a/coregrind/m_execontext.c +++ b/coregrind/m_execontext.c @@ -36,8 +36,6 @@ #include "pub_core_options.h" #include "pub_core_stacktrace.h" #include "pub_core_machine.h" // VG_(get_IP) -#include "pub_core_vki.h" // To keep pub_core_threadstate.h happy -#include "pub_core_libcsetjmp.h" // Ditto #include "pub_core_threadstate.h" // VG_(is_valid_tid) #include "pub_core_execontext.h" // self diff --git a/coregrind/m_gdbserver/m_gdbserver.c b/coregrind/m_gdbserver/m_gdbserver.c index d8a0303a48..2238ca5ed2 100644 --- a/coregrind/m_gdbserver/m_gdbserver.c +++ b/coregrind/m_gdbserver/m_gdbserver.c @@ -33,12 +33,9 @@ #include "pub_core_libcproc.h" #include "pub_core_libcprint.h" #include "pub_core_mallocfree.h" -#include "pub_core_libcsetjmp.h" #include "pub_core_threadstate.h" #include "pub_core_gdbserver.h" #include "pub_core_options.h" -#include "pub_core_libcsetjmp.h" -#include "pub_core_threadstate.h" #include "pub_core_transtab.h" #include "pub_core_hashtable.h" #include "pub_core_xarray.h" diff --git a/coregrind/m_gdbserver/server.h b/coregrind/m_gdbserver/server.h index 1e010cab75..1dd0d1a064 100644 --- a/coregrind/m_gdbserver/server.h +++ b/coregrind/m_gdbserver/server.h @@ -40,7 +40,6 @@ #include "pub_core_libcassert.h" #include "pub_core_libcbase.h" #include "pub_core_options.h" -#include "pub_core_libcsetjmp.h" #include "pub_core_threadstate.h" #include "pub_core_gdbserver.h" #include "pub_core_vki.h" diff --git a/coregrind/m_initimg/initimg-darwin.c b/coregrind/m_initimg/initimg-darwin.c index b317248995..cd6e2ffe1c 100644 --- a/coregrind/m_initimg/initimg-darwin.c +++ b/coregrind/m_initimg/initimg-darwin.c @@ -47,7 +47,6 @@ #include "pub_core_ume.h" #include "pub_core_options.h" #include "pub_core_tooliface.h" /* VG_TRACK */ -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" /* ThreadArchState */ #include "priv_initimg_pathscan.h" #include "pub_core_initimg.h" /* self */ diff --git a/coregrind/m_initimg/initimg-linux.c b/coregrind/m_initimg/initimg-linux.c index 0ed65c409d..cd0b7f3046 100644 --- a/coregrind/m_initimg/initimg-linux.c +++ b/coregrind/m_initimg/initimg-linux.c @@ -48,7 +48,6 @@ #include "pub_core_options.h" #include "pub_core_syscall.h" #include "pub_core_tooliface.h" /* VG_TRACK */ -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" /* ThreadArchState */ #include "priv_initimg_pathscan.h" #include "pub_core_initimg.h" /* self */ diff --git a/coregrind/m_libcassert.c b/coregrind/m_libcassert.c index 2f8026c74b..5d3a07b37e 100644 --- a/coregrind/m_libcassert.c +++ b/coregrind/m_libcassert.c @@ -31,7 +31,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_gdbserver.h" #include "pub_core_aspacemgr.h" diff --git a/coregrind/m_machine.c b/coregrind/m_machine.c index 2551b10934..99afb7ddc4 100644 --- a/coregrind/m_machine.c +++ b/coregrind/m_machine.c @@ -29,7 +29,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // setjmp facilities #include "pub_core_threadstate.h" #include "pub_core_libcassert.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_main.c b/coregrind/m_main.c index 9ca26e3235..9f98e11a75 100644 --- a/coregrind/m_main.c +++ b/coregrind/m_main.c @@ -31,7 +31,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_xarray.h" #include "pub_core_clientstate.h" diff --git a/coregrind/m_mallocfree.c b/coregrind/m_mallocfree.c index 65a2b7d9ef..1f543c9d15 100644 --- a/coregrind/m_mallocfree.c +++ b/coregrind/m_mallocfree.c @@ -38,7 +38,6 @@ #include "pub_core_libcprint.h" #include "pub_core_mallocfree.h" #include "pub_core_options.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" // For VG_INVALID_THREADID #include "pub_core_gdbserver.h" #include "pub_core_transtab.h" diff --git a/coregrind/m_scheduler/scheduler.c b/coregrind/m_scheduler/scheduler.c index 5d3b175199..80fdf6a997 100644 --- a/coregrind/m_scheduler/scheduler.c +++ b/coregrind/m_scheduler/scheduler.c @@ -62,7 +62,6 @@ #include "pub_core_debuglog.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" // __NR_sched_yield -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_clientstate.h" #include "pub_core_aspacemgr.h" diff --git a/coregrind/m_sigframe/sigframe-amd64-darwin.c b/coregrind/m_sigframe/sigframe-amd64-darwin.c index 38682f318e..20402bfcfe 100644 --- a/coregrind/m_sigframe/sigframe-amd64-darwin.c +++ b/coregrind/m_sigframe/sigframe-amd64-darwin.c @@ -34,7 +34,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-amd64-linux.c b/coregrind/m_sigframe/sigframe-amd64-linux.c index e0154016c7..0c1c7b4163 100644 --- a/coregrind/m_sigframe/sigframe-amd64-linux.c +++ b/coregrind/m_sigframe/sigframe-amd64-linux.c @@ -33,7 +33,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-arm-linux.c b/coregrind/m_sigframe/sigframe-arm-linux.c index 7ae7f07291..b374257ae8 100644 --- a/coregrind/m_sigframe/sigframe-arm-linux.c +++ b/coregrind/m_sigframe/sigframe-arm-linux.c @@ -38,7 +38,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-arm64-linux.c b/coregrind/m_sigframe/sigframe-arm64-linux.c index 1a7c984e9b..6e80659dd8 100644 --- a/coregrind/m_sigframe/sigframe-arm64-linux.c +++ b/coregrind/m_sigframe/sigframe-arm64-linux.c @@ -33,7 +33,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-mips32-linux.c b/coregrind/m_sigframe/sigframe-mips32-linux.c index 0e27e01d99..4b23dc746a 100644 --- a/coregrind/m_sigframe/sigframe-mips32-linux.c +++ b/coregrind/m_sigframe/sigframe-mips32-linux.c @@ -34,7 +34,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-mips64-linux.c b/coregrind/m_sigframe/sigframe-mips64-linux.c index cacf9ce7d0..5e0f44ac17 100644 --- a/coregrind/m_sigframe/sigframe-mips64-linux.c +++ b/coregrind/m_sigframe/sigframe-mips64-linux.c @@ -34,7 +34,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" /* to keep _threadstate.h happy */ #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-ppc32-linux.c b/coregrind/m_sigframe/sigframe-ppc32-linux.c index 467814dc5c..8047f275f4 100644 --- a/coregrind/m_sigframe/sigframe-ppc32-linux.c +++ b/coregrind/m_sigframe/sigframe-ppc32-linux.c @@ -36,7 +36,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-ppc64-linux.c b/coregrind/m_sigframe/sigframe-ppc64-linux.c index 5e90e54aea..ec4d883a22 100644 --- a/coregrind/m_sigframe/sigframe-ppc64-linux.c +++ b/coregrind/m_sigframe/sigframe-ppc64-linux.c @@ -36,7 +36,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-s390x-linux.c b/coregrind/m_sigframe/sigframe-s390x-linux.c index 0568922727..fb70c76352 100644 --- a/coregrind/m_sigframe/sigframe-s390x-linux.c +++ b/coregrind/m_sigframe/sigframe-s390x-linux.c @@ -33,7 +33,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-tilegx-linux.c b/coregrind/m_sigframe/sigframe-tilegx-linux.c index b9de920aa5..3448ff8860 100644 --- a/coregrind/m_sigframe/sigframe-tilegx-linux.c +++ b/coregrind/m_sigframe/sigframe-tilegx-linux.c @@ -35,7 +35,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-x86-darwin.c b/coregrind/m_sigframe/sigframe-x86-darwin.c index e3da65d034..01f87da020 100644 --- a/coregrind/m_sigframe/sigframe-x86-darwin.c +++ b/coregrind/m_sigframe/sigframe-x86-darwin.c @@ -34,7 +34,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" #include "pub_core_libcbase.h" diff --git a/coregrind/m_sigframe/sigframe-x86-linux.c b/coregrind/m_sigframe/sigframe-x86-linux.c index a09aaf2e54..3db225126a 100644 --- a/coregrind/m_sigframe/sigframe-x86-linux.c +++ b/coregrind/m_sigframe/sigframe-x86-linux.c @@ -33,7 +33,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_aspacemgr.h" /* find_segment */ #include "pub_core_libcbase.h" diff --git a/coregrind/m_signals.c b/coregrind/m_signals.c index 47a345f703..0bfdf73b33 100644 --- a/coregrind/m_signals.c +++ b/coregrind/m_signals.c @@ -203,7 +203,6 @@ #include "pub_core_vki.h" #include "pub_core_vkiscnums.h" #include "pub_core_debuglog.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_xarray.h" #include "pub_core_clientstate.h" diff --git a/coregrind/m_stacktrace.c b/coregrind/m_stacktrace.c index c4672e6c27..c0d4c1185c 100644 --- a/coregrind/m_stacktrace.c +++ b/coregrind/m_stacktrace.c @@ -30,7 +30,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_debuginfo.h" // XXX: circular dependency #include "pub_core_aspacemgr.h" // For VG_(is_addressable)() diff --git a/coregrind/m_threadstate.c b/coregrind/m_threadstate.c index b3adcde862..e6b7b7ba93 100644 --- a/coregrind/m_threadstate.c +++ b/coregrind/m_threadstate.c @@ -30,7 +30,6 @@ #include "pub_core_basics.h" #include "pub_core_vki.h" -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" #include "pub_core_mallocfree.h" // VG_(malloc) #include "pub_core_libcassert.h" diff --git a/coregrind/m_translate.c b/coregrind/m_translate.c index 28ac906c65..86a3f4a0dd 100644 --- a/coregrind/m_translate.c +++ b/coregrind/m_translate.c @@ -53,7 +53,6 @@ #include "pub_core_dispatch.h" // VG_(run_innerloop__dispatch_{un}profiled) // VG_(run_a_noredir_translation__return_point) -#include "pub_core_libcsetjmp.h" // to keep _threadstate.h happy #include "pub_core_threadstate.h" // VexGuestArchState #include "pub_core_trampoline.h" // VG_(ppctoc_magic_redirect_return_stub) -- 2.47.3