From b749c923373c7ccdc68ba2aed42c614e6a11d353 Mon Sep 17 00:00:00 2001 From: Jeremy Allison Date: Tue, 15 Oct 2019 13:28:11 -0700 Subject: [PATCH] s3: smbd: SMB1 UNIX extensions - remove dead code. We no longer set delete_on_fail on return from mknod. Signed-off-by: Jeremy Allison Reviewed-by: Volker Lendecke Autobuild-User(master): Jeremy Allison Autobuild-Date(master): Wed Nov 6 19:31:00 UTC 2019 on sn-devel-184 --- source3/smbd/trans2.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c index 24a1ad083de..d5000e83cb1 100644 --- a/source3/smbd/trans2.c +++ b/source3/smbd/trans2.c @@ -8103,7 +8103,6 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn, uid_t set_owner = (uid_t)SMB_UID_NO_CHANGE; gid_t set_grp = (uid_t)SMB_GID_NO_CHANGE; NTSTATUS status = NT_STATUS_OK; - bool delete_on_fail = False; enum perm_type ptype; files_struct *all_fsps = NULL; bool modify_mtime = true; @@ -8222,12 +8221,6 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn, if (ret != 0) { status = map_nt_error_from_unix(errno); - if (delete_on_fail) { - SMB_VFS_UNLINKAT(conn, - conn->cwd_fsp, - smb_fname, - 0); - } return status; } } @@ -8256,12 +8249,6 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn, } if (ret != 0) { status = map_nt_error_from_unix(errno); - if (delete_on_fail) { - SMB_VFS_UNLINKAT(conn, - conn->cwd_fsp, - smb_fname, - 0); - } return status; } } -- 2.47.3