From b90a16408a5c45ce5312384f278e19d09f8dda4d Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Thu, 12 May 2016 08:13:04 +0100 Subject: [PATCH] cookerdata: Fix log messages and ensure we exit The string formatting wasn't correct and we should exit if we hit errors here similar to the other exception handlers. Signed-off-by: Richard Purdie --- lib/bb/cookerdata.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index 50259a9a073..fba95afa54f 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -192,7 +192,8 @@ def catch_parse_error(func): fn, _, _, _ = traceback.extract_tb(tb, 1)[0] if not fn.startswith(bbdir): break - parselog.critical("Unable to parse %s", fn, exc_info=(exc_class, exc, tb)) + parselog.critical("Unable to parse %s" % fn, exc_info=(exc_class, exc, tb)) + sys.exit(1) except bb.parse.ParseError as exc: parselog.critical(str(exc)) sys.exit(1) -- 2.47.3