From b9a4d8d088c2ce47ae7961739f0816cfd065a156 Mon Sep 17 00:00:00 2001 From: Cr <631807682@qq.com> Date: Wed, 9 Oct 2019 23:49:23 +0800 Subject: [PATCH] refactor(reactivity): use function isSymbol instead of typeof (#155) --- packages/reactivity/src/baseHandlers.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts index ff163179f8..fe07600d9f 100644 --- a/packages/reactivity/src/baseHandlers.ts +++ b/packages/reactivity/src/baseHandlers.ts @@ -2,19 +2,19 @@ import { reactive, readonly, toRaw } from './reactive' import { OperationTypes } from './operations' import { track, trigger } from './effect' import { LOCKED } from './lock' -import { isObject, hasOwn } from '@vue/shared' +import { isObject, hasOwn, isSymbol } from '@vue/shared' import { isRef } from './ref' const builtInSymbols = new Set( Object.getOwnPropertyNames(Symbol) .map(key => (Symbol as any)[key]) - .filter(value => typeof value === 'symbol') + .filter(isSymbol) ) function createGetter(isReadonly: boolean) { return function get(target: any, key: string | symbol, receiver: any) { const res = Reflect.get(target, key, receiver) - if (typeof key === 'symbol' && builtInSymbols.has(key)) { + if (isSymbol(key) && builtInSymbols.has(key)) { return res } if (isRef(res)) { -- 2.47.3