From bcbfae42795f4dadb35a8f59a0165467708c3e71 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Sat, 13 Feb 2021 11:16:17 +0100 Subject: [PATCH] lib: Fix samba_sockaddr_[get|set]_port Signed-off-by: Volker Lendecke Reviewed-by: Jeremy Allison --- lib/util/util_net.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/util/util_net.c b/lib/util/util_net.c index 5e62fefa146..fe474dc16be 100644 --- a/lib/util/util_net.c +++ b/lib/util/util_net.c @@ -1117,12 +1117,12 @@ bool sockaddr_storage_to_samba_sockaddr( bool samba_sockaddr_set_port(struct samba_sockaddr *sa, uint16_t port) { if (sa->u.sa.sa_family == AF_INET) { - sa->u.in.sin_port = port; + sa->u.in.sin_port = htons(port); return true; } #ifdef HAVE_IPV6 if (sa->u.sa.sa_family == AF_INET6) { - sa->u.in6.sin6_port = port; + sa->u.in6.sin6_port = htons(port); return true; } #endif @@ -1132,12 +1132,12 @@ bool samba_sockaddr_set_port(struct samba_sockaddr *sa, uint16_t port) bool samba_sockaddr_get_port(const struct samba_sockaddr *sa, uint16_t *port) { if (sa->u.sa.sa_family == AF_INET) { - *port = sa->u.in.sin_port; + *port = ntohs(sa->u.in.sin_port); return true; } #ifdef HAVE_IPV6 if (sa->u.sa.sa_family == AF_INET6) { - *port = sa->u.in6.sin6_port; + *port = ntohs(sa->u.in6.sin6_port); return true; } #endif -- 2.47.3