From bcd218151f2a612086e427fda6455d042c2035c4 Mon Sep 17 00:00:00 2001 From: James Coglan Date: Mon, 10 Jun 2024 16:21:32 +0100 Subject: [PATCH] resolved: tests for dns_packet_append_answer(); NS, CNAME, PTR and MX records --- src/resolve/test-dns-packet-append.c | 185 ++++++++++++++++++++++++++- 1 file changed, 182 insertions(+), 3 deletions(-) diff --git a/src/resolve/test-dns-packet-append.c b/src/resolve/test-dns-packet-append.c index a9f2520dc00..6eb2357074c 100644 --- a/src/resolve/test-dns-packet-append.c +++ b/src/resolve/test-dns-packet-append.c @@ -500,13 +500,13 @@ TEST(packet_append_answer_single_a) { _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; DnsResourceRecord *rr = NULL; - answer = dns_answer_new(1); - ASSERT_NOT_NULL(answer); - rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "example.com"); ASSERT_NOT_NULL(rr); rr->ttl = 3601; rr->a.in_addr.s_addr = htobe32(0xc0a8017f); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); dns_answer_add(answer, rr, 1, 0, NULL); dns_resource_record_unref(rr); @@ -537,4 +537,183 @@ TEST(packet_append_answer_single_a) { ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); } +TEST(packet_append_answer_single_ns) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; + DnsResourceRecord *rr = NULL; + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_NS, "example.com"); + ASSERT_NOT_NULL(rr); + rr->ttl = 3601; + rr->ns.name = strdup("ns1.example.com"); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); + dns_answer_add(answer, rr, 1, 0, NULL); + dns_resource_record_unref(rr); + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(1, 0, 1, 0, 1, 1, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->ancount = htobe16(dns_answer_size(answer)); + + ASSERT_OK(dns_packet_append_answer(packet, answer, NULL)); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_QR | BIT_AA | BIT_RD, BIT_RA | DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* NS */ 0x00, 0x02, + /* IN */ 0x00, 0x01, + /* ttl */ 0x00, 0x00, 0x0e, 0x11, + /* rdata */ 0x00, 0x06, + /* name */ 0x03, 'n', 's', '1', + 0xc0, 0x0c + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + +TEST(packet_append_answer_single_cname) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; + DnsResourceRecord *rr = NULL; + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"); + ASSERT_NOT_NULL(rr); + rr->ttl = 3601; + rr->cname.name = strdup("example.com"); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); + dns_answer_add(answer, rr, 1, 0, NULL); + dns_resource_record_unref(rr); + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(1, 0, 1, 0, 1, 1, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->ancount = htobe16(dns_answer_size(answer)); + + ASSERT_OK(dns_packet_append_answer(packet, answer, NULL)); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_QR | BIT_AA | BIT_RD, BIT_RA | DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x03, 'w', 'w', 'w', + 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* CNAME */ 0x00, 0x05, + /* IN */ 0x00, 0x01, + /* ttl */ 0x00, 0x00, 0x0e, 0x11, + /* rdata */ 0x00, 0x02, + /* name */ 0xc0, 0x10 + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + +TEST(packet_append_answer_single_ptr) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; + DnsResourceRecord *rr = NULL; + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_PTR, "127.1.168.192.in-addr.arpa"); + ASSERT_NOT_NULL(rr); + rr->ttl = 3601; + rr->ptr.name = strdup("example.com"); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); + dns_answer_add(answer, rr, 1, 0, NULL); + dns_resource_record_unref(rr); + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(1, 0, 1, 0, 1, 1, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->ancount = htobe16(dns_answer_size(answer)); + + ASSERT_OK(dns_packet_append_answer(packet, answer, NULL)); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_QR | BIT_AA | BIT_RD, BIT_RA | DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x03, '1', '2', '7', + 0x01, '1', + 0x03, '1', '6', '8', + 0x03, '1', '9', '2', + 0x07, 'i', 'n', '-', 'a', 'd', 'd', 'r', + 0x04, 'a', 'r', 'p', 'a', + 0x00, + /* PTR */ 0x00, 0x0c, + /* IN */ 0x00, 0x01, + /* ttl */ 0x00, 0x00, 0x0e, 0x11, + /* rdata */ 0x00, 0x0d, + /* name */ 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00 + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + +TEST(packet_append_answer_single_mx) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + _cleanup_(dns_answer_unrefp) DnsAnswer *answer = NULL; + DnsResourceRecord *rr = NULL; + + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_MX, "example.com"); + ASSERT_NOT_NULL(rr); + rr->ttl = 3601; + rr->mx.priority = 9; + rr->mx.exchange = strdup("mail.example.com"); + + answer = dns_answer_new(1); + ASSERT_NOT_NULL(answer); + dns_answer_add(answer, rr, 1, 0, NULL); + dns_resource_record_unref(rr); + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(1, 0, 1, 0, 1, 1, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->ancount = htobe16(dns_answer_size(answer)); + + ASSERT_OK(dns_packet_append_answer(packet, answer, NULL)); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_QR | BIT_AA | BIT_RD, BIT_RA | DNS_RCODE_SUCCESS, + 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* MX */ 0x00, 0x0f, + /* IN */ 0x00, 0x01, + /* ttl */ 0x00, 0x00, 0x0e, 0x11, + /* rdata */ 0x00, 0x09, + /* priority */ 0x00, 0x09, + /* name */ 0x04, 'm', 'a', 'i', 'l', + 0xc0, 0x0c + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + DEFINE_TEST_MAIN(LOG_DEBUG) -- 2.47.3