From bfa3236c6c3550eb3f53f3fb98738aaabe77c689 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 2 Feb 2022 10:44:36 +0100 Subject: [PATCH] MINOR: quic: Remove a useless test in quic_get_dgram_dcid() This test is already done when entering quic_get_dgram_dcid(). --- src/xprt_quic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index 0f9987e026..23126e7beb 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -5429,7 +5429,7 @@ static int quic_get_dgram_dcid(unsigned char *buf, const unsigned char *end, minlen = long_header ? QUIC_LONG_PACKET_MINLEN : QUIC_SHORT_PACKET_MINLEN + QUIC_HAP_CID_LEN; skip = long_header ? QUIC_LONG_PACKET_DCID_OFF : QUIC_SHORT_PACKET_DCID_OFF; - if (end - buf <= minlen || !(*buf & QUIC_PACKET_FIXED_BIT)) + if (end - buf <= minlen) goto err; buf += skip; -- 2.47.3