From c2c707bd45426df6edc5cf9f5f9fd857bd9926a9 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann Date: Wed, 9 Apr 2025 14:23:01 +0200 Subject: [PATCH] apm-emulation: hide an unused variable The driver_version variable is only used inside of an #ifdef block, which leads to a W=1 warning: drivers/char/apm-emulation.c:144:19: error: 'driver_version' defined but not used [-Werror=unused-const-variable=] Move this into the function using it. Fixes: 7726942fb15e ("[APM] Add shared version of APM emulation") Acked-by: Jiri Kosina Signed-off-by: Arnd Bergmann Link: https://lore.kernel.org/r/20250409122314.2848028-9-arnd@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/char/apm-emulation.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/char/apm-emulation.c b/drivers/char/apm-emulation.c index e795390b070fa..53ce352f7197d 100644 --- a/drivers/char/apm-emulation.c +++ b/drivers/char/apm-emulation.c @@ -141,9 +141,6 @@ static struct apm_queue kapmd_queue; static DEFINE_MUTEX(state_lock); -static const char driver_version[] = "1.13"; /* no spaces */ - - /* * Compatibility cruft until the IPAQ people move over to the new @@ -435,6 +432,8 @@ static struct miscdevice apm_device = { */ static int proc_apm_show(struct seq_file *m, void *v) { + static const char driver_version[] = "1.13"; /* no spaces */ + struct apm_power_info info; char *units; -- 2.47.3