From c3aa22272df5389c76cf4ed42d22a71d637ce924 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Fri, 25 Apr 2025 10:52:39 +0200 Subject: [PATCH] cmake: use `CMAKE_COMPILE_WARNING_AS_ERROR` if available It's available in CMake >= 3.24. Ref: https://cmake.org/cmake/help/latest/variable/CMAKE_COMPILE_WARNING_AS_ERROR.html Closes #17183 --- CMake/PickyWarnings.cmake | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index 2ab9dc3517..610def004d 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -27,10 +27,14 @@ set(_picky "") set(_picky_nocheck "") # not to pass to feature checks if(CURL_WERROR) - if(MSVC) - list(APPEND _picky_nocheck "-WX") - else() # llvm/clang and gcc style options - list(APPEND _picky_nocheck "-Werror") + if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.24) + set(CMAKE_COMPILE_WARNING_AS_ERROR ON) + else() + if(MSVC) + list(APPEND _picky_nocheck "-WX") + else() # llvm/clang and gcc style options + list(APPEND _picky_nocheck "-Werror") + endif() endif() if((CMAKE_C_COMPILER_ID STREQUAL "GNU" AND -- 2.47.3