From c7ce62cf65463c7ea6474d0373c56fb3edeb0e2a Mon Sep 17 00:00:00 2001 From: Mike Bayer Date: Sat, 4 May 2013 15:26:28 -0400 Subject: [PATCH] - OK we have -w sql passing for: sqlite, postgresql, oursql 2.7 + 3.3, mysqldb 2.7 --- lib/sqlalchemy/engine/default.py | 2 +- setup.cfg | 1 + test/sql/test_types.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/sqlalchemy/engine/default.py b/lib/sqlalchemy/engine/default.py index e52aac427c..e9645f3639 100644 --- a/lib/sqlalchemy/engine/default.py +++ b/lib/sqlalchemy/engine/default.py @@ -221,7 +221,7 @@ class DefaultDialect(interfaces.Dialect): ) row = cursor.fetchone() - return isinstance(row[0], util.string_types) + return isinstance(row[0], util.text_type) except self.dbapi.Error as de: util.warn("Exception attempting to " "detect unicode returns: %r" % de) diff --git a/setup.cfg b/setup.cfg index 92bdbc40f4..9c53e32ad1 100644 --- a/setup.cfg +++ b/setup.cfg @@ -32,6 +32,7 @@ pg8000=postgresql+pg8000://scott:tiger@127.0.0.1:5432/test postgresql_jython=postgresql+zxjdbc://scott:tiger@127.0.0.1:5432/test mysql_jython=mysql+zxjdbc://scott:tiger@127.0.0.1:5432/test mysql=mysql://scott:tiger@127.0.0.1:3306/test +oursql=mysql+oursql://scott:tiger@127.0.0.1:3306/test pymysql=mysql+pymysql://scott:tiger@127.0.0.1:3306/test?use_unicode=0&charset=utf8 oracle=oracle://scott:tiger@127.0.0.1:1521 oracle8=oracle://scott:tiger@127.0.0.1:1521/?use_ansi=0 diff --git a/test/sql/test_types.py b/test/sql/test_types.py index a1845778e5..dbb475b98c 100644 --- a/test/sql/test_types.py +++ b/test/sql/test_types.py @@ -1349,7 +1349,7 @@ class NumericRawSQLTest(fixtures.TestBase): metadata = self.metadata self._fixture(metadata, Integer, 45) val = testing.db.execute("select val from t").scalar() - assert isinstance(val, int) + assert isinstance(val, util.int_types) eq_(val, 45) @testing.provide_metadata -- 2.47.3