From c9fb8c7c4a748a9205629f08d16afbb61d8e875b Mon Sep 17 00:00:00 2001 From: tblume Date: Wed, 21 Jun 2017 19:29:58 +0200 Subject: [PATCH] only check signature job error if signature job exists (#6118) otherwise it will segfault when accessing signature jobs error status --- src/import/pull-raw.c | 2 +- src/import/pull-tar.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/import/pull-raw.c b/src/import/pull-raw.c index a15eac1f1fe..974e42d7ce3 100644 --- a/src/import/pull-raw.c +++ b/src/import/pull-raw.c @@ -498,7 +498,7 @@ static void raw_pull_job_on_finished(PullJob *j) { if (!raw_pull_is_done(i)) return; - if (i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) { + if (i->signature_job && i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) { log_error_errno(j->error, "Failed to retrieve signature file, cannot verify. (Try --verify=no?)"); r = i->signature_job->error; diff --git a/src/import/pull-tar.c b/src/import/pull-tar.c index d4b599ba951..16ce9016502 100644 --- a/src/import/pull-tar.c +++ b/src/import/pull-tar.c @@ -315,7 +315,7 @@ static void tar_pull_job_on_finished(PullJob *j) { if (!tar_pull_is_done(i)) return; - if (i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) { + if (i->signature_job && i->checksum_job->style == VERIFICATION_PER_DIRECTORY && i->signature_job->error != 0) { log_error_errno(j->error, "Failed to retrieve signature file, cannot verify. (Try --verify=no?)"); r = i->signature_job->error; -- 2.47.3