From ca7a5af664504cbe13240e5bc538efbcef4f6162 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Fri, 20 Dec 2019 17:26:27 +0100 Subject: [PATCH] BUG/MINOR: state-file: do not leak memory on parse errors Issue #417 reports a possible memory leak in the state-file loading code. There's one such place in the loop which corresponds to parsing errors where the curreently allocated line is not freed when dropped. In any case this is very minor in that no more than the file's length may be lost in the worst case, considering that the whole file is kept anyway in case of success. This fix addresses this. It should be backported to 2.1. --- src/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/server.c b/src/server.c index 466da441b4..6212a420ed 100644 --- a/src/server.c +++ b/src/server.c @@ -3616,7 +3616,7 @@ void apply_server_state(void) srv_state_parse_line(mybuf, global_file_version, params, srv_params); if (params[0] == NULL) - continue; + goto nextline; /* bkname */ bkname = params[1]; -- 2.47.3