From cb9ff7b4c5bcb896de49e4d3949a3ad539a77b0e Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Fri, 12 Apr 2024 07:34:54 +0200 Subject: [PATCH] s4:rpc_server: Use lpcfg_dns_hostname() in dns_server.c Signed-off-by: Andreas Schneider Reviewed-by: Andrew Bartlett --- source4/dns_server/dns_server.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/source4/dns_server/dns_server.c b/source4/dns_server/dns_server.c index 0a36c1c29e2..4e6e0d32a6c 100644 --- a/source4/dns_server/dns_server.c +++ b/source4/dns_server/dns_server.c @@ -822,7 +822,7 @@ static NTSTATUS dns_task_init(struct task_server *task) int ret; static const char * const attrs_none[] = { NULL}; struct ldb_message *dns_acc; - char *hostname_lower; + const char *dns_hostname = NULL; char *dns_spn; bool ok; @@ -882,11 +882,14 @@ static NTSTATUS dns_task_init(struct task_server *task) return NT_STATUS_UNSUCCESSFUL; } - hostname_lower = strlower_talloc(dns, lpcfg_netbios_name(task->lp_ctx)); - dns_spn = talloc_asprintf(dns, "DNS/%s.%s", - hostname_lower, - lpcfg_dnsdomain(task->lp_ctx)); - TALLOC_FREE(hostname_lower); + dns_hostname = lpcfg_dns_hostname(task->lp_ctx); + if (dns_hostname == NULL) { + return NT_STATUS_NO_MEMORY; + } + dns_spn = talloc_asprintf(dns, "DNS/%s", dns_hostname); + if (dns_spn == NULL) { + return NT_STATUS_NO_MEMORY; + } ret = dsdb_search_one(dns->samdb, dns, &dns_acc, ldb_get_default_basedn(dns->samdb), LDB_SCOPE_SUBTREE, -- 2.47.3