From cc0ed15feccfed8748619d0ee309f12dbe4f77e0 Mon Sep 17 00:00:00 2001 From: Volker Lendecke Date: Wed, 20 Nov 2024 12:54:05 +0100 Subject: [PATCH] smbd: Always init symlink_err in filename_convert_dirfsp_nosymlink() Make sure that we don't leave symlink_err in the caller uninitialized. Signed-off-by: Volker Lendecke Reviewed-by: Ralph Boehme --- source3/smbd/filename.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source3/smbd/filename.c b/source3/smbd/filename.c index b9bdda3ae0d..f37387100ea 100644 --- a/source3/smbd/filename.c +++ b/source3/smbd/filename.c @@ -808,8 +808,6 @@ filename_convert_dirfsp_nosymlink(TALLOC_CTX *mem_ctx, } lnk->unparsed_path_length = unparsed; - *_symlink_err = symlink_err; - goto fail; } } @@ -1054,6 +1052,8 @@ done: return NT_STATUS_OK; fail: + *_symlink_err = symlink_err; + /* * If open_stream_pathref_fsp() returns an error, smb_fname_rel->fsp * has been set to NULL, so we must free base_fsp separately -- 2.47.3