From cc9ff79d86c64cc25c5618866c95f308204716dd Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Fri, 4 Dec 2020 11:53:48 +1300 Subject: [PATCH] dbcheck: err_normalise-mismatch_replace: no msg if no error Signed-off-by: Douglas Bagnall Reviewed-by: Noel Power Autobuild-User(master): Noel Power Autobuild-Date(master): Wed Dec 9 17:04:23 UTC 2020 on sn-devel-184 --- python/samba/dbchecker.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python/samba/dbchecker.py b/python/samba/dbchecker.py index 67583376323..28b56edaafb 100644 --- a/python/samba/dbchecker.py +++ b/python/samba/dbchecker.py @@ -513,10 +513,11 @@ newSuperior: %s""" % (str(from_dn), str(to_rdn), str(to_base))) def err_normalise_mismatch_replace(self, dn, attrname, values): '''fix attribute normalisation and/or sort errors''' normalised = self.samdb.dsdb_normalise_attributes(self.samdb_schema, attrname, values) - self.report("ERROR: Normalisation error for attribute '%s' in '%s'" % (attrname, dn)) - self.report("Values/Order of values do/does not match: %s/%s!" % (values, list(normalised))) if list(normalised) == values: + # how we got here is a mystery. return + self.report("ERROR: Normalisation error for attribute '%s' in '%s'" % (attrname, dn)) + self.report("Values/Order of values do/does not match: %s/%s!" % (values, list(normalised))) if not self.confirm_all("Fix normalisation for '%s' from '%s'?" % (attrname, dn), 'fix_all_normalisation'): self.report("Not fixing attribute '%s'" % attrname) return -- 2.47.3