From cd7ca79e6c924724a8b233dbc9affa513bd92993 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 17 Jul 2019 16:57:03 +0200 Subject: [PATCH] MINOR: http: check the source address via conn_get_src() in sample fetch functions In smp_fetch_url32_src() and smp_fetch_base32_src() it's better to validate that the source address was properly initialized since it will soon be dynamic, thus let's call conn_get_src(). --- src/http_fetch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/http_fetch.c b/src/http_fetch.c index 08e71f4b40..a5c70008ac 100644 --- a/src/http_fetch.c +++ b/src/http_fetch.c @@ -1079,7 +1079,7 @@ static int smp_fetch_base32_src(const struct arg *args, struct sample *smp, cons struct buffer *temp; struct connection *cli_conn = objt_conn(smp->sess->origin); - if (!cli_conn) + if (!cli_conn || !conn_get_src(cli_conn)) return 0; if (!smp_fetch_base32(args, smp, kw, private)) @@ -1784,7 +1784,7 @@ static int smp_fetch_url32_src(const struct arg *args, struct sample *smp, const struct buffer *temp; struct connection *cli_conn = objt_conn(smp->sess->origin); - if (!cli_conn) + if (!cli_conn || !conn_get_src(cli_conn)) return 0; if (!smp_fetch_url32(args, smp, kw, private)) -- 2.47.3