From d0511dd8df00a116ee71411ac4c514c6d68d70f5 Mon Sep 17 00:00:00 2001 From: Joel Rosdahl Date: Tue, 4 Aug 2020 21:07:09 +0200 Subject: [PATCH] Remove unnecessary compiler behavior test in modules test suite MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The “preprocessor output” test in the modules test suite only tests compiler behavior, and the string it looks for in the preprocessed output is different for older and newer Clang versions. It seems like a kind of a probing call, but I don’t see why we would want to probe the compiler behavior in this case so I’ll just remove it. Fixes #601. --- test/suites/modules.bash | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/test/suites/modules.bash b/test/suites/modules.bash index dcd02abd6..35dc04c24 100644 --- a/test/suites/modules.bash +++ b/test/suites/modules.bash @@ -3,7 +3,7 @@ SUITE_modules_PROBE() { echo "-fmodules/-fcxx-modules not supported by compiler" return fi - } +} SUITE_modules_SETUP() { unset CCACHE_NODIRECT @@ -29,11 +29,6 @@ EOF } SUITE_modules() { - # ------------------------------------------------------------------------- - TEST "preprocessor output" - $COMPILER -fmodules -fcxx-modules test1.cpp -E > test1.preprocessed.cpp - expect_file_contains "test1.preprocessed.cpp" "#pragma clang module import Test1" - # ------------------------------------------------------------------------- TEST "fall back to real compiler, no sloppiness" -- 2.47.3