From d06d5d6b68f39c7f75f1130f984efa78c291fb57 Mon Sep 17 00:00:00 2001 From: Todd Short Date: Wed, 19 Oct 2022 10:13:35 -0400 Subject: [PATCH] Fix coverity 1516094 uninit Reviewed-by: Tomas Mraz Reviewed-by: Paul Dale (Merged from https://github.com/openssl/openssl/pull/19440) --- ssl/statem/statem_clnt.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ssl/statem/statem_clnt.c b/ssl/statem/statem_clnt.c index ac4fb4e00df..3021bc19525 100644 --- a/ssl/statem/statem_clnt.c +++ b/ssl/statem/statem_clnt.c @@ -3732,7 +3732,10 @@ CON_FUNC_RETURN tls_construct_client_compressed_certificate(SSL_CONNECTION *sc, err: SSLfatal(sc, SSL_AD_INTERNAL_ERROR, ERR_R_INTERNAL_ERROR); out: - WPACKET_cleanup(&tmppkt); + if (buf != NULL) { + /* If |buf| is NULL, then |tmppkt| could not have been initialized */ + WPACKET_cleanup(&tmppkt); + } BUF_MEM_free(buf); COMP_CTX_free(comp); return ret; -- 2.47.3