From d164f495208bee0dc3ac4c15c11ffc89fe7e4fd2 Mon Sep 17 00:00:00 2001 From: Marcel Raad Date: Sun, 16 Feb 2025 21:52:52 +0100 Subject: [PATCH] openssl: remove bad `goto`s into other scope All the `goto` did in these cases was effectively `return 0`, so just use that explicitly. Closes https://github.com/curl/curl/pull/16356 --- lib/vtls/openssl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vtls/openssl.c b/lib/vtls/openssl.c index 3e49a95534..d5f55d7c46 100644 --- a/lib/vtls/openssl.c +++ b/lib/vtls/openssl.c @@ -1452,7 +1452,7 @@ int cert_stuff(struct Curl_easy *data, failf(data, "No cert found in the openssl store: %s", ossl_strerror(ERR_get_error(), error_buffer, sizeof(error_buffer))); - goto fail; + return 0; } if(SSL_CTX_use_certificate(ctx, cert) != 1) { @@ -1728,7 +1728,7 @@ fail: failf(data, "No private key found in the openssl store: %s", ossl_strerror(ERR_get_error(), error_buffer, sizeof(error_buffer))); - goto fail; + return 0; } if(SSL_CTX_use_PrivateKey(ctx, priv_key) != 1) { -- 2.47.3