From d2f54775d3fe5e3ef6d00121ac7ab382dd58ddcd Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Thu, 23 May 2019 12:21:46 +1200 Subject: [PATCH] selftest: Run samba3.srvsvc tests covering more of the srvsvc server Found by LCOV. Some of the failures should be fixed by setting "restrict anonymous = 2" as requested by bug 12775 Signed-off-by: Andrew Bartlett Reviewed-by: Gary Lockyer --- selftest/knownfail.d/srvsvc | 24 ++++++++++++++++++++++++ source3/selftest/tests.py | 5 ++++- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 selftest/knownfail.d/srvsvc diff --git a/selftest/knownfail.d/srvsvc b/selftest/knownfail.d/srvsvc new file mode 100644 index 00000000000..63444c8eda0 --- /dev/null +++ b/selftest/knownfail.d/srvsvc @@ -0,0 +1,24 @@ +# Except where noted these are missing RPCs with just give a simple +# fault (mapped to NT_STATUS_RPC_PROCNUM_OUT_OF_RANGE\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareGetInfo\(ad_member\) +# Level 501 is supported in the s3 srvsrv server +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnum\(ad_member\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetTransportEnum\(ad_member\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnumAll\(ad_member\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevQEnum\(ad_member\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevEnum\(ad_member\) +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareGetInfo\(ad_member\) +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnum\(ad_member\) +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnumAll\(ad_member\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareGetInfo\(ad_dc\) +# Level 501 is supported in the s3 srvsrv server +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnum\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetTransportEnum\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetShareEnumAll\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevQEnum\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc \(admin access\).NetCharDevEnum\(ad_dc\) +# These should be fixed by setting 'restrict anonymous = 2' by default +# per https://bugzilla.samba.org/show_bug.cgi?id=12775 +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareGetInfo\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnum\(ad_dc\) +^samba3.rpc.srvsvc.srvsvc anonymous access.NetShareEnumAll\(ad_dc\) diff --git a/source3/selftest/tests.py b/source3/selftest/tests.py index 80fc3e69438..e9124f22a54 100755 --- a/source3/selftest/tests.py +++ b/source3/selftest/tests.py @@ -464,7 +464,7 @@ rpc = ["rpc.authcontext", "rpc.samba3.bind", "rpc.samba3.srvsvc", "rpc.samba3.sh "rpc.samr.priv", "rpc.samr.passwords.validate", "rpc.netlogon.admin", "rpc.schannel", "rpc.schannel2", "rpc.bench-schannel1", "rpc.schannel_anon_setpw", "rpc.join", "rpc.bind", - "rpc.initshutdown", "rpc.wkssvc"] + "rpc.initshutdown", "rpc.wkssvc", "rpc.srvsvc"] local = ["local.nss"] @@ -671,6 +671,9 @@ for t in tests: plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD') elif t == "rpc.wkssvc": plansmbtorture4testsuite(t, "ad_member", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD') + elif t == "rpc.srvsvc": + plansmbtorture4testsuite(t, "ad_member", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD') + plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$DC_USERNAME%$DC_PASSWORD') else: plansmbtorture4testsuite(t, "nt4_dc", '//$SERVER_IP/tmp -U$USERNAME%$PASSWORD') plansmbtorture4testsuite(t, "ad_dc", '//$SERVER/tmp -U$USERNAME%$PASSWORD') -- 2.47.3