From d4f4c7c4d48f64f093a0204e83097eaf01936d25 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gabriel=20Loi=C3=A1cono?= <32134586+loiacon@users.noreply.github.com> Date: Tue, 26 Nov 2019 23:00:32 -0300 Subject: [PATCH] fix(runtime-core): renderList with default value when source is undefined (#498) --- packages/runtime-core/__tests__/helpers/renderList.spec.ts | 6 ++++++ packages/runtime-core/src/helpers/renderList.ts | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/runtime-core/__tests__/helpers/renderList.spec.ts b/packages/runtime-core/__tests__/helpers/renderList.spec.ts index d55bffbd8d..e28c6a004c 100644 --- a/packages/runtime-core/__tests__/helpers/renderList.spec.ts +++ b/packages/runtime-core/__tests__/helpers/renderList.spec.ts @@ -41,4 +41,10 @@ describe('renderList', () => { renderList(iterable(), (item, index) => `node ${index}: ${item}`) ).toEqual(['node 0: 1', 'node 1: 2', 'node 2: 3']) }) + + it('should return empty array when source is undefined', () => { + expect( + renderList(undefined, (item, index) => `node ${index}: ${item}`) + ).toEqual([]) + }) }) diff --git a/packages/runtime-core/src/helpers/renderList.ts b/packages/runtime-core/src/helpers/renderList.ts index 693c87bcba..f45020d418 100644 --- a/packages/runtime-core/src/helpers/renderList.ts +++ b/packages/runtime-core/src/helpers/renderList.ts @@ -31,6 +31,8 @@ export function renderList( ret[i] = renderItem(source[key], key, i) } } + } else { + ret = [] } - return ret! + return ret } -- 2.47.3