From d536e8b5e93e6011f5251bf8bb9be01bf52e8fd8 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Tue, 20 Feb 2024 18:03:14 +0800 Subject: [PATCH] logind-session-dbus: drop unneeded unref_and_replace If there's pending s->upgrade_message, we already return early above. --- src/login/logind-session-dbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/login/logind-session-dbus.c b/src/login/logind-session-dbus.c index ae71e2fc7b6..0411d85c336 100644 --- a/src/login/logind-session-dbus.c +++ b/src/login/logind-session-dbus.c @@ -451,7 +451,7 @@ static int method_set_class(sd_bus_message *message, void *userdata, sd_bus_erro session_set_class(s, class); - unref_and_replace_full(s->upgrade_message, message, sd_bus_message_ref, sd_bus_message_unref); + s->upgrade_message = sd_bus_message_ref(message); r = session_send_upgrade_reply(s, /* error= */ NULL); if (r < 0) -- 2.47.3