From d6489d8e4160772cbcc90042d2e2892f6c77cef7 Mon Sep 17 00:00:00 2001 From: Roger Dingledine Date: Mon, 31 Jan 2005 00:33:32 +0000 Subject: [PATCH] lay a trap for situations where we connection_free something that's still on one of the lists. in particular, this will detect situations where we mark-for-close and then free it ourselves. svn:r3475 --- src/or/connection.c | 2 ++ src/or/main.c | 5 +++++ src/or/or.h | 1 + 3 files changed, 8 insertions(+) diff --git a/src/or/connection.c b/src/or/connection.c index 7aa6fc5d9c..59da957ccb 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -143,6 +143,8 @@ connection_t *connection_new(int type) { void connection_free(connection_t *conn) { tor_assert(conn); tor_assert(conn->magic == CONNECTION_MAGIC); + tor_assert(!connection_in_array(conn)); + tor_assert(!connection_is_on_closeable_list(conn)); if (!connection_is_listener(conn)) { buf_free(conn->inbuf); diff --git a/src/or/main.c b/src/or/main.c index edcc0a8dc2..cd3768c5ee 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -206,6 +206,11 @@ add_connection_to_closeable_list(connection_t *conn) smartlist_add(closeable_connection_lst, conn); } +/** Return 1 if conn is on the closeable list, else return 0. */ +int connection_is_on_closeable_list(connection_t *conn) { + return smartlist_isin(closeable_connection_lst, conn); +} + /** Return true iff conn is in the current poll array. */ int connection_in_array(connection_t *conn) { int i; diff --git a/src/or/or.h b/src/or/or.h index bdc880df69..443b57b2bb 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -1393,6 +1393,7 @@ int connection_add(connection_t *conn); int connection_remove(connection_t *conn); int connection_in_array(connection_t *conn); void add_connection_to_closeable_list(connection_t *conn); +int connection_is_on_closeable_list(connection_t *conn); void get_connection_array(connection_t ***array, int *n); -- 2.47.3