From d7da41a9bef66a428f6f11a37bad4adfb6f89278 Mon Sep 17 00:00:00 2001 From: Douglas Bagnall Date: Wed, 22 Nov 2023 14:44:30 +1300 Subject: [PATCH] libcli/security: simplify wire claim conversion mem, 2/3: one tree These values would have leaked in the event of failure (but only onto the caller mem_ctx, which might be fleeting -- especially as its security token is now failing). Signed-off-by: Douglas Bagnall Reviewed-by: Andrew Bartlett --- libcli/security/claims-conversions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libcli/security/claims-conversions.c b/libcli/security/claims-conversions.c index a1e36d4724f..8103ede55ae 100644 --- a/libcli/security/claims-conversions.c +++ b/libcli/security/claims-conversions.c @@ -807,7 +807,7 @@ NTSTATUS token_claims_to_claims_v1(TALLOC_CTX *mem_ctx, } } - value = talloc(mem_ctx, int64_t); + value = talloc(claims, int64_t); if (value == NULL) { talloc_free(tmp_ctx); return NT_STATUS_NO_MEMORY; @@ -854,7 +854,7 @@ NTSTATUS token_claims_to_claims_v1(TALLOC_CTX *mem_ctx, } } - value = talloc(mem_ctx, uint64_t); + value = talloc(claims, uint64_t); if (value == NULL) { talloc_free(tmp_ctx); return NT_STATUS_NO_MEMORY; -- 2.47.3