From dc95763757bf4b7a2139de5c93dc62bae70dd01d Mon Sep 17 00:00:00 2001 From: Ralph Boehme Date: Fri, 16 Feb 2024 16:12:43 +0100 Subject: [PATCH] winbindd: rename variable old_status to was_online in wb_cache_name_to_sid() A lot easier to make sense of the complex logic when using this name. Signed-off-by: Ralph Boehme Reviewed-by: Stefan Metzmacher --- source3/winbindd/winbindd_cache.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index 0e426876582..9a334e2ae97 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -1819,10 +1819,10 @@ NTSTATUS wb_cache_name_to_sid(struct winbindd_domain *domain, enum lsa_SidType *type) { NTSTATUS status; - bool old_status; + bool was_online; const char *dom_name; - old_status = domain->online; + was_online = domain->online; status = wcache_name_to_sid(domain, domain_name, name, sid, type); if (!NT_STATUS_EQUAL(status, NT_STATUS_NOT_FOUND)) { @@ -1840,12 +1840,12 @@ NTSTATUS wb_cache_name_to_sid(struct winbindd_domain *domain, if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT) || NT_STATUS_EQUAL(status, NT_STATUS_DOMAIN_CONTROLLER_NOT_FOUND)) { - if (!domain->internal && old_status) { + if (!domain->internal && was_online) { set_domain_offline(domain); } if (!domain->internal && !domain->online && - old_status) { + was_online) { NTSTATUS cache_status; cache_status = wcache_name_to_sid(domain, domain_name, name, sid, type); return cache_status; -- 2.47.3