From dcbfee246f35970f65d08a4555e25b956b9aba9c Mon Sep 17 00:00:00 2001 From: =?utf8?q?Alexander=20F=C3=A6r=C3=B8y?= Date: Sat, 23 Jun 2018 03:24:10 +0200 Subject: [PATCH] Fix memory leak in frac_nodes_with_descriptors(). This patch fixes a memory leak in frac_nodes_with_descriptors() where we might return without free'ing the bandwidths variable. See: Coverity CID 1437451. --- src/or/routerlist.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/or/routerlist.c b/src/or/routerlist.c index f21a222cd2..f73ec9baa1 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -2765,6 +2765,8 @@ frac_nodes_with_descriptors(const smartlist_t *sl, if (node_has_descriptor(node)) n_with_descs++; }); + + tor_free(bandwidths); return ((double)n_with_descs) / (double)smartlist_len(sl); } -- 2.47.3