From e144507b0983399fb3dbcf6535cfbead22a6c5e4 Mon Sep 17 00:00:00 2001 From: Brett Cannon Date: Fri, 4 Feb 2011 20:24:02 +0000 Subject: [PATCH] There was a possibility that the initialization of _sqlite, when it failed, would lead to a decref of a NULL. Fixes issue #11110. --- Misc/NEWS | 2 ++ Modules/_sqlite/module.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Misc/NEWS b/Misc/NEWS index 5df056d827ab..efb84882ec99 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -15,6 +15,8 @@ Core and Builtins Library ------- +- Issue #11110: Fix a potential decref of a NULL in sqlite3. + - Issue #8275: Fix passing of callback arguments with ctypes under Win64. Patch by Stan Mihai. diff --git a/Modules/_sqlite/module.c b/Modules/_sqlite/module.c index 3292daee83fe..cbc3b8e90bea 100644 --- a/Modules/_sqlite/module.c +++ b/Modules/_sqlite/module.c @@ -329,7 +329,7 @@ PyMODINIT_FUNC PyInit__sqlite3(void) (pysqlite_statement_setup_types() < 0) || (pysqlite_prepare_protocol_setup_types() < 0) ) { - Py_DECREF(module); + Py_XDECREF(module); return NULL; } -- 2.47.3